-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make contiguous case for chainerx::AddAt
faster
#8299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e8a53e
to
ebf56f0
Compare
chainerx::AddAt
fasterchainerx::AddAt
faster
emcastillo
commented
Oct 17, 2019
chainerx::AddAt
fasterchainerx::AddAt
faster
b78a2b4
to
0833218
Compare
0833218
to
77da801
Compare
PTAL 😄 |
asi1024
reviewed
Oct 24, 2019
Jenkins and flexCI, test this please. |
Jenkins CI test (for commit d85cc1d, target branch master) failed with status FAILURE. |
Jenkins and flexCI, test this please. |
Jenkins CI test (for commit d85cc1d, target branch master) succeeded! |
LGTM. |
shinh
added a commit
to shinh/chainer-compiler
that referenced
this pull request
Oct 29, 2019
Thanks to chainer/chainer#8299 contiguous case is significantly faster.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked it similar to #8295
IndexableArrays uses the 1D specialized template whenever it is possible.
For 40 runs of a pathological case, execution time decreased from 0.18 seconds to 0.02
Please note that
addat
is not currently exposed to the python API.