Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #8413

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Remove unused function #8413

merged 1 commit into from
Nov 13, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Nov 12, 2019

This function is unused since #8295 and #8299

@niboshi niboshi added the cat:code-fix Code refactoring that does not change the behavior. label Nov 12, 2019
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting it

@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. ChainerX Related to ChainerX. labels Nov 12, 2019
@emcastillo emcastillo added this to the v7.0.0 milestone Nov 12, 2019
@emcastillo emcastillo self-assigned this Nov 12, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2b219f4, target branch master) failed with status FAILURE.

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2b219f4, target branch master) succeeded!

@mergify mergify bot merged commit 83b9763 into chainer:master Nov 13, 2019
@niboshi niboshi deleted the unused-function branch November 13, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:code-fix Code refactoring that does not change the behavior. ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants