Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LinkTestCase for L.GroupNormalization #8343

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Use LinkTestCase for L.GroupNormalization #8343

merged 4 commits into from
Oct 31, 2019

Conversation

toslunar
Copy link
Member

It seems chainer.testing.LinkTestCase supports backprop test with higher-prec dtype by overwriting parameters. Use it and close #6911.

@toslunar toslunar added the cat:test Test or CI related. label Oct 30, 2019
@toslunar
Copy link
Member Author

It succeeded with repeat(2000).

@niboshi
Copy link
Member

niboshi commented Oct 31, 2019

Jenkins, test this please

@niboshi
Copy link
Member

niboshi commented Oct 31, 2019

Oh, overlooked travis failure. Please fix it.

[2019-10-30 07:58:43] /home/travis/build/chainer/chainer/tests/chainer_tests/links_tests/normalization_tests/test_group_normalization.py:7:1: F401 'chainer.gradient_check' imported but unused

@niboshi niboshi self-assigned this Oct 31, 2019
@niboshi niboshi added this to the v7.0.0 milestone Oct 31, 2019
@niboshi niboshi added the to-be-backported Pull request that should be backported. label Oct 31, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit d8ebdca, target branch master) failed with status FAILURE.

@niboshi
Copy link
Member

niboshi commented Oct 31, 2019

Jenkins, test this please

@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Oct 31, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 440e707, target branch master) succeeded!

@mergify mergify bot merged commit 2ba41af into chainer:master Oct 31, 2019
niboshi pushed a commit to niboshi/chainer that referenced this pull request Oct 31, 2019
@mergify @niboshi
Merge pull request chainer#8343 from toslunar/gn-test
c76640c 
Use `LinkTestCase` for `L.GroupNormalization`
@niboshi niboshi mentioned this pull request Oct 31, 2019
Merged
@toslunar toslunar deleted the gn-test branch October 31, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

test_group_normalization is flaky
3 participants
@toslunar @niboshi @chainer-ci