Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce shape in ChainerX linalg test #8349

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Oct 31, 2019

I don't know there's a special reason to test (6, 6) in addition to (3, 3).
Reducing it for (possibly)

  • Shorter test runtime
  • Ease of investigation in case of failure
  • Numerical stability

@hvy
Copy link
Member

hvy commented Oct 31, 2019

Jenkins, test this please.

@hvy
Copy link
Member

hvy commented Oct 31, 2019

LGTM!

@hvy hvy added this to the v7.0.0 milestone Oct 31, 2019
@hvy hvy added cat:test Test or CI related. ChainerX Related to ChainerX. labels Oct 31, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 9f4e170, target branch master) succeeded!

@hvy hvy added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Oct 31, 2019
@mergify mergify bot merged commit 8ba8ae3 into chainer:master Nov 1, 2019
@niboshi niboshi deleted the test-linalg-shape branch November 1, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants