Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different docker image for each base development branch #8350

Merged
merged 5 commits into from
Nov 11, 2019

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented Oct 31, 2019

This fixes the issue that CuPy master is used for Chainer v6 tests.

After this got merged, configure CuPy webhook to trigger https://ci.preferred.jp/chainer.docker.py25and35.push/ and https://ci.preferred.jp/chainer.docker.py37.push/ for v6 branch.

@kmaehashi kmaehashi added cat:test Test or CI related. to-be-backported Pull request that should be backported. labels Oct 31, 2019
.pfnci/script.sh Outdated Show resolved Hide resolved
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

Co-Authored-By: Takeshi Watanabe <take-cheeze@users.noreply.github.com>
Copy link
Member

@take-cheeze take-cheeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Let's test this in pfnci!

@take-cheeze
Copy link
Member

/test

@kmaehashi
Copy link
Member Author

Finally it's working!

@take-cheeze
Copy link
Member

Jenkins, test this please!

@take-cheeze take-cheeze added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 8, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4584c7f, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4584c7f, target branch master) failed with status FAILURE.

@take-cheeze
Copy link
Member

Jenkins, test this please!

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4584c7f, target branch master) succeeded!

@mergify mergify bot merged commit b35ce74 into chainer:master Nov 11, 2019
take-cheeze pushed a commit to take-cheeze/chainer that referenced this pull request Nov 11, 2019
…r-each-base

Use different docker image for each base development branch
@kmaehashi kmaehashi deleted the use-different-image-for-each-base branch November 11, 2019 04:53
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants