Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChainerX fallback condition in batch normalization #8359

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

toslunar
Copy link
Member

Fix #8327

@toslunar toslunar added cat:bug Bug report or fix. to-be-backported Pull request that should be backported. labels Oct 31, 2019
@emcastillo emcastillo self-assigned this Nov 1, 2019
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo emcastillo added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 1, 2019
@emcastillo emcastillo added this to the v7.0.0 milestone Nov 1, 2019
@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 06119c0, target branch master) succeeded!

@mergify mergify bot merged commit 599af28 into chainer:master Nov 1, 2019
@toslunar toslunar deleted the fix-8327 branch November 1, 2019 07:21
emcastillo pushed a commit to emcastillo/chainer that referenced this pull request Nov 1, 2019
Fix ChainerX fallback condition in batch normalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bug report or fix. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_chainerx_is_supported in F.batch_normalization is wrong
3 participants