Fix negative tests for chainerx.linalg.*
#8371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
added
the
st:test-and-merge
|
Jenkins, test this please |
emcastillo
removed
the
st:test-and-merge
|
waiting to reach consensus on using |
|
Jenkins CI test (for commit be8b428, target branch master) failed with status FAILURE. |
|
PTAL. |
emcastillo
reviewed
Nov 6, 2019
emcastillo
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
LGTM, @toslunar is there anything you want to point out before merging?
🙂
|
Jenkins, test this please |
|
Jenkins CI test (for commit 431d984, target branch master) succeeded! |
emcastillo
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using
forward_accept_errorsand replace them withpytest.raisesfor the negative tests for thechainerx.linalgroutines.Also added some missing tests and removed seemingly redundant parameterizations.
C.f. #6764 (comment) and #8362.