Remove chainerx dependency from test backends #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
added
the
st:test-and-merge
|
Jenkins, test this please |
|
Jenkins CI test (for commit 28a0f95, target branch master) succeeded! |
|
Hm, I'm failing to build ChainerX on my mac after this change with undefined symbols (methods from [ 44%] Building CXX object chainerx/CMakeFiles/chainerx_base.dir/backprop_mode.o
Undefined symbols for architecture x86_64:
Undefined symbols for architecture x86_64:
"chainerx::native::NativeBackend::CreateDevice(int)", referenced from:
"chainerx::native::NativeBackend::CreateDevice(int)", referenced from:
vtable for (anonymous namespace)::Backend1 in backend1.o
vtable for (anonymous namespace)::Backend0 in backend0.o
"chainerx::native::NativeBackend::SupportsTransfer(chainerx::Device&, chainerx::Device&)", referenced from:
vtable for (anonymous namespace)::Backend1 in backend1.o
"chainerx::native::NativeBackend::SupportsTransfer(chainerx::Device&, chainerx::Device&)", referenced from:
"chainerx::native::NativeBackend::GetGlobalKernelRegistry()", referenced from:
vtable for (anonymous namespace)::Backend0 in backend0.o
(anonymous namespace)::Backend1::GetParentKernelRegistry() in backend1.o
"chainerx::Backend::Initialize()", referenced from:
"chainerx::native::NativeBackend::GetGlobalKernelRegistry()", referenced from:
vtable for (anonymous namespace)::Backend1 in backend1.o
(anonymous namespace)::Backend0::GetParentKernelRegistry() in backend0.o
"chainerx::Backend::Backend(chainerx::Context&)", referenced from:
chainerx::native::NativeBackend::NativeBackend(chainerx::Context&) in backend1.o
"chainerx::Backend::Initialize()", referenced from:
"chainerx::Backend::~Backend()", referenced from:
chainerx::native::NativeBackend::~NativeBackend() in backend1.o
"chainerx::native::NativeBackend::GetDeviceCount() const", referenced from:
vtable for (anonymous namespace)::Backend1 in backend1.o
"typeinfo for chainerx::native::NativeBackend", referenced from:
typeinfo for (anonymous namespace)::Backend1 in backend1.o
"vtable for chainerx::native::NativeBackend", referenced from:
chainerx::native::NativeBackend::NativeBackend(chainerx::Context&) in backend1.o
NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
vtable for (anonymous namespace)::Backend0 in backend0.o
"chainerx::Backend::Backend(chainerx::Context&)", referenced from:
chainerx::native::NativeBackend::NativeBackend(chainerx::Context&) in backend0.o
"chainerx::Backend::~Backend()", referenced from:
chainerx::native::NativeBackend::~NativeBackend() in backend0.o
"chainerx::native::NativeBackend::GetDeviceCount() const", referenced from:
vtable for (anonymous namespace)::Backend0 in backend0.o
"typeinfo for chainerx::native::NativeBackend", referenced from:
ld: symbol(s) not found for architecture x86_64
typeinfo for (anonymous namespace)::Backend0 in backend0.o
"vtable for chainerx::native::NativeBackend", referenced from:
chainerx::native::NativeBackend::NativeBackend(chainerx::Context&) in backend0.o
NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [chainerx/backend_testdata/backends/backend1.so] Error 1
make[2]: *** [chainerx/backend_testdata/backends/backend0.so] Error 1
make[1]: *** [chainerx/backend_testdata/CMakeFiles/backend1.so.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [chainerx/backend_testdata/CMakeFiles/backend0.so.dir/all] Error 2
[ 44%] Building CXX object chainerx/native/CMakeFiles/chainerx_native.dir/native_device/binary.o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are not necessary.