Use PYBIND11_EXPORT instead of visibility hack
#8437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
changed the title
PYBIND11_EXPORT instead of visibility hack
niboshi
force-pushed
the
use-pybind11-export
branch
2 times, most recently
from
8747035
to
4436240
Compare
niboshi
force-pushed
the
use-pybind11-export
branch
from
4436240
to
d27326e
Compare
|
Jenkins, test this please. |
|
Jenkins CI test (for commit d27326e, target branch master) succeeded! |
|
Thanks, it LGTM. Let me just rerun the CI. Jenkins, test this please. |
hvy
added
cat:test
|
Jenkins CI test (for commit d27326e, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of tweaking the default visibility (#5936), this PR applies
PYBIND11_EXPORTto relevant classes, as suggested in pybind/pybind11#1272 (comment).