Use FunctionTestCase to test F.decov
#8522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toslunar
added
cat:test
emcastillo
reviewed
Dec 25, 2019
|
|
||
|
|
||
| def _deconv(h): | ||
| def _decov(h): | ||
| h = cuda.to_cpu(h) |
There was a problem hiding this comment.
I think that forward_expected only gets numpy arrays so this call may not be necessary.
|
Jenkins, test this please |
emcastillo
added
the
st:test-and-merge
|
Jenkins CI test (for commit 59c12e8, target branch master) succeeded! |
toslunar
pushed a commit
to toslunar/chainer
that referenced
this pull request
Dec 25, 2019
Use `FunctionTestCase` to test `F.decov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionTestCasedefaults tonumerical_grad_dtype = numpy.float64, which would reduce the flakiness of the test.Close #8512.