Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Skip chainerx.fromfile test when dtype is bool_ and mode is text #8524

Merged
merged 1 commit into from
Dec 26, 2019
Merged

[backport] Skip chainerx.fromfile test when dtype is bool_ and mode is text #8524

merged 1 commit into from
Dec 26, 2019

Conversation

emcastillo
Copy link
Member

Backport of #8521

@mergify
Merge pull request chainer#8521 from takagi/test-chainerx-fromfile
69ba658 
Skip `chainerx.fromfile` test when dtype is bool_ and mode is text
@emcastillo emcastillo added backport Pull request that is backported from a more recent version. cat:test Test or CI related. labels Dec 26, 2019
@emcastillo
Copy link
Member Author

[automatic post] Jenkins, test this please.

@toslunar toslunar self-assigned this Dec 26, 2019
@toslunar toslunar added this to the v6.7.0 milestone Dec 26, 2019
toslunar
toslunar approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Dec 26, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 69ba658, target branch v6) succeeded!

@toslunar
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 69ba658, target branch v6) succeeded!

@mergify mergify bot merged commit 95b79c7 into chainer:v6 Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
backport Pull request that is backported from a more recent version. cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v6.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emcastillo @chainer-ci @toslunar