This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
change interface of point/transforms #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakuyume
reviewed
Mar 13, 2019
| .. csv-table:: | ||
| :header: name, shape, dtype, format | ||
|
|
||
| :obj:`point`, ":math:`[(K, 2)]` or :math:`(R, K, 2)`", \ |
There was a problem hiding this comment.
In Args section, ndarray comes first.
point (~numpy.ndarray or list of arrays)
I prefer to use the same order here.
:obj:`point`, ":math:`(R, K, 2)` or :math:`[(K, 2)]`"
Hakuyume
reviewed
Mar 14, 2019
| np.testing.assert_equal(out, point_expected) | ||
|
|
||
| def test_flip_point_list(self): | ||
| point = [np.random.uniform( | ||
| low=0., high=32., size=(12, 2))] |
There was a problem hiding this comment.
How about using point with more than one samples?
Hakuyume
reviewed
Apr 3, 2019
| def test_flip_point_list(self): | ||
| point = [ | ||
| np.random.uniform(low=0., high=32., size=(12, 2)), | ||
| np.random.uniform(low=0., high=32., size=(12, 2)), |
There was a problem hiding this comment.
I prefer to use two arrays of different shapes (e.g. (12, 2) and (10, 2)).
| def test_resize_point_list(self): | ||
| point = [ | ||
| np.random.uniform(low=0., high=32., size=(12, 2)), | ||
| np.random.uniform(low=0., high=32., size=(12, 2)) |
| def test_translate_point_list(self): | ||
| point = [ | ||
| np.random.uniform(low=0., high=32., size=(10, 2)), | ||
| np.random.uniform(low=0., high=32., size=(10, 2)) |
Hakuyume
approved these changes
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume
pointas[(K, 2)]instead of(K, 2).