This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Change interface of vis_point #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakuyume
reviewed
Feb 26, 2019
|
|
||
| :obj:`img`, ":math:`(3, H, W)`", :obj:`float32`, \ | ||
| "RGB, :math:`[0, 255]`" | ||
| :obj:`point`, ":math:`[(K, 2)]`", :obj:`float32`, ":math:`(y, x)`" |
There was a problem hiding this comment.
If we assumes all instances have the same K, it should be (N, K, 2) (N is the number of instances).
There was a problem hiding this comment.
In #808, R is used for the number of instances. It's better to make them consistent.
There was a problem hiding this comment.
We don't assume that all instances have the same K for this function.
That is why I left the documentation to accept lists.
There was a problem hiding this comment.
So, these two lines should be like (~numpy.ndarray or list of arrays).
chainercv/chainercv/visualizations/vis_point.py
Lines 24 to 25 in 07f136e
|
fixed |
Hakuyume
reviewed
Mar 14, 2019
|
|
||
| :obj:`img`, ":math:`(3, H, W)`", :obj:`float32`, \ | ||
| "RGB, :math:`[0, 255]`" | ||
| :obj:`point`, ":math:`[(K, 2)]` or :math:`(R, K, 2)`", \ |
Hakuyume
reviewed
Apr 3, 2019
| "RGB, :math:`[0, 255]`" | ||
| :obj:`point`, ":math:`(R, K, 2)` or :math:`[(K, 2)]`", \ | ||
| :obj:`float32`, ":math:`(y, x)`" | ||
| :obj:`visible`, ":math:`[(K,)]` or :math:`(R, K)`", :obj:`bool`, -- |
There was a problem hiding this comment.
":math:`(R, K)` or :math:`[(K,)]`"
Hakuyume
approved these changes
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume
pointas[(K, 2)]instead of(K, 2).