Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual parallel example #121

Merged
merged 8 commits into from
Sep 21, 2017
Merged

Conversation

levelfour
Copy link
Contributor

@levelfour levelfour commented Sep 4, 2017

MNIST data-parallel + model+parallel example. This can be executed on the even number of processes.

@levelfour levelfour changed the title [WIP] Dual parallel example Dual parallel example Sep 4, 2017
@@ -20,6 +20,9 @@ def rank(self):
def size(self):
return self.mpi_comm.size

def split(self, color, key):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want an explanation on the parameter 'color'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some detailed comments.

@@ -0,0 +1,151 @@
#!/usr/bin/env python
# coding: utf-8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a short description of what this example demonstrates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some explanation in README.

self.add_link(MLP1Sub(n_units, n_out), rank_in=0, rank_out=0)


def main():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this examples requires that comm.size % 2 == 0 ?

Copy link
Contributor Author

@levelfour levelfour Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The number of processes must be even.
(I added assertion)

@keisukefukuda keisukefukuda merged commit 9af3dd6 into chainer:master Sep 21, 2017
@levelfour levelfour deleted the dual-parallel-example branch October 26, 2017 05:44
@levelfour levelfour restored the dual-parallel-example branch October 26, 2017 05:45
@levelfour levelfour deleted the dual-parallel-example branch October 26, 2017 05:49
@iwiwi iwiwi added this to the v1.1.0 milestone Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants