-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual parallel example #121
Dual parallel example #121
Conversation
@@ -20,6 +20,9 @@ def rank(self): | |||
def size(self): | |||
return self.mpi_comm.size | |||
|
|||
def split(self, color, key): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want an explanation on the parameter 'color'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some detailed comments.
@@ -0,0 +1,151 @@ | |||
#!/usr/bin/env python | |||
# coding: utf-8 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a short description of what this example demonstrates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some explanation in README.
self.add_link(MLP1Sub(n_units, n_out), rank_in=0, rank_out=0) | ||
|
||
|
||
def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this examples requires that comm.size % 2 == 0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The number of processes must be even.
(I added assertion)
MNIST data-parallel + model+parallel example. This can be executed on the even number of processes.