Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Use eye icon #255

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Use eye icon #255

merged 6 commits into from
Jan 29, 2019

Conversation

ofk
Copy link
Member

@ofk ofk commented Jan 15, 2019

merge #254 first

Before
2019-01-15 14 59 59

After
2019-01-15 14 58 10

@disktnk disktnk added this to the v0.9.0 milestone Jan 22, 2019
@disktnk disktnk requested a review from gky360 January 26, 2019 09:53
Copy link
Contributor

@gky360 gky360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got the following warning on my console.

Warning: Received `false` for a non-boolean attribute `indeterminate`.

If you want to write it to the DOM, pass a string instead: indeterminate="false" or indeterminate={value.toString()}.

If you used to conditionally omit it with indeterminate={condition && value}, pass indeterminate={condition ? value : undefined} instead.
    in input (created by VisibilityCheckbox)
    in label (created by VisibilityCheckbox)
    in VisibilityCheckbox (created by ExperimentsTable)
    in div (created by ReactTable)
    in div (created by ThComponent)
    in ThComponent (created by ReactTable)
    in div (created by TrComponent)
    in TrComponent (created by ReactTable)
    in div (created by Thead)
    in Thead (created by ReactTable)
    in div (created by TableComponent)
    in TableComponent (created by ReactTable)
    in div (created by ReactTable)
    in ReactTable (created by ExperimentsTable)
    in ExperimentsTable (created by PlotContainer)
    in div (created by PlotContainer)
    in div (created by PlotContainer)
    in div (created by Container)
    in Container (created by PlotContainer)
    in div (created by PlotContainer)
    in PlotContainer (created by Connect(PlotContainer))
    in Connect(PlotContainer) (created by RouterContext)
    in RouterContext (created by Router)
    in Router (created by Root)
    in Provider (created by Root)
    in Root

Copy link
Contributor

@gky360 gky360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@gky360 gky360 merged commit 18ebc13 into chainer:master Jan 29, 2019
@ofk ofk deleted the use-eye-icon branch June 14, 2019 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants