Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Upgrade eslint #257

Merged
merged 11 commits into from
Feb 1, 2019
Merged

Upgrade eslint #257

merged 11 commits into from
Feb 1, 2019

Conversation

ofk
Copy link
Member

@ofk ofk commented Feb 1, 2019

I removed many disabled eslint rules.
As a result, this project's coding style is airbnb style except for arrow-parens and comma-dangle.

@ofk ofk requested a review from disktnk February 1, 2019 03:58
@disktnk disktnk added this to the v0.10.0 milestone Feb 1, 2019
Copy link
Member

@disktnk disktnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@disktnk disktnk merged commit 9fb9a34 into chainer:master Feb 1, 2019
@ofk ofk deleted the upgrade-eslint branch June 14, 2019 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants