This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Line Smoothing #333
Merged
Line Smoothing #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gky360
reviewed
Nov 6, 2019
| {selectedResults.map((resultId) => ( | ||
| <React.Fragment key={resultId}> | ||
| {selectedLogKeys.map((logKey) => ( | ||
| <Check |
There was a problem hiding this comment.
When we have, for example, 10 results and all that 10 results have the same log key (e.g. main/loss ), and we toggle one checkbox, all 10 checkboxes change at the same time.
Is this behavior intended?
There was a problem hiding this comment.
I didn't intend it. I tried with only one log. Sorry. 🙇
I adopt the same axis config instead of line setting.
In other words, the same name is grouped together, so in this example it is one main/loss .
Thank you for your report.
|
Fixed 💪 |
|
self-merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #302