Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak cli generate-keys output #3943

Merged
merged 2 commits into from Sep 6, 2023
Merged

Conversation

dandanlen
Copy link
Collaborator

I noticed while writing the documenation that some of the command output was wrong. Also Slightly modified some spelling / capitalisation.

  • Capitalised Account ID etc.
  • Display the whole Ethereum Key insteaf of 0xabcd...1234
  • Use the correct command line arguments in the help output: --seed-phrase and --path.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3943 (1e2dd04) into main (b195c43) will decrease coverage by 0%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #3943    +/-   ##
======================================
- Coverage     73%     72%    -0%     
======================================
  Files        367     366     -1     
  Lines      56051   56789   +738     
  Branches   56051   56789   +738     
======================================
+ Hits       40649   40946   +297     
- Misses     13343   13756   +413     
- Partials    2059    2087    +28     

see 37 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

api/bin/chainflip-cli/src/main.rs Outdated Show resolved Hide resolved
Co-authored-by: Jamie Ford <jamie@chainflip.io>
@dandanlen dandanlen enabled auto-merge (squash) September 6, 2023 09:43
@dandanlen dandanlen merged commit 3d38229 into main Sep 6, 2023
44 checks passed
@dandanlen dandanlen deleted the fix/generate-keys-output-text branch September 6, 2023 10:18
dandanlen added a commit that referenced this pull request Sep 6, 2023
Co-authored-by: Jamie Ford <jamie@chainflip.io>
dandanlen added a commit that referenced this pull request Sep 6, 2023
Co-authored-by: Jamie Ford <jamie@chainflip.io>
syan095 added a commit that referenced this pull request Sep 8, 2023
…on-integration

* origin/main:
  fix: scale encoding skip phantom data (#3967)
  chore: make platform team code owner of CI settings.toml and localnet (#3957)
  fix: prefer finalize_signed_extrinsic in engine (#3956)
  fix: CanonicalAssetPair encoding issue (#3958)
  chore(bouncer): Update sdk to 0.0.40 (#3945)
  fix: tweak cli generate-keys output (#3943)
  chore: add `preinst` script unit tests 🧪 (#3942)
  Better LP/Broker API RPC Errors (#3931)
  fix: update substrate ref to use Kademlia fix (#3941)
  doc: update funding readme with redemption restrictions (#3914)
  feat: PRO-474 broadcast safe mode (#3902)
  feat: more forgiving dot address parsing (#3938)
  fix: duplicate logging (#3939)
  feat: new lp interface (#3886)

# Conflicts:
#	Cargo.lock
#	state-chain/cf-integration-tests/Cargo.toml
#	state-chain/cf-integration-tests/src/authorities.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants