chore(bouncer): Update sdk to 0.0.40 #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
force-pushed
the
chore/update-sdk-2
branch
from
33c53aa
to
b219a3c
Compare
niklasnatter
force-pushed
the
chore/update-sdk-2
branch
from
b219a3c
to
6cc5ca6
Compare
niklasnatter
commented
Sep 5, 2023
| @@ -1,7 +1,7 @@ | |||
| import { getBtcClient } from './utils'; | |||
|
|
|||
| export async function getBtcBalance(bitcoinAddress: string): Promise<number> { | |||
| const client = getBtcClient(process.env.BTC_ENDPOINT); | |||
| const client = getBtcClient(); | |||
There was a problem hiding this comment.
method has no parameters
niklasnatter
commented
Sep 5, 2023
| @@ -15,7 +15,7 @@ async function getGovernanceMembers(): Promise<string[]> { | |||
| async function setGovernanceMembers(members: string[]) { | |||
| const chainflip = await getChainflipApi(); | |||
|
|
|||
| await submitGovernanceExtrinsic(chainflip.tx.governance.newMembershipSet(members), true); | |||
| await submitGovernanceExtrinsic(chainflip.tx.governance.newMembershipSet(members)); | |||
There was a problem hiding this comment.
method has a single parameter only
Codecov Report
@@ Coverage Diff @@
## main #3945 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 366 366
Lines 56789 56789
Branches 56789 56789
=====================================
- Hits 40952 40949 -3
- Misses 13752 13754 +2
- Partials 2085 2086 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
martin-chainflip
approved these changes
Sep 5, 2023
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
syan095
added a commit
that referenced
this pull request
Sep 8, 2023
…on-integration * origin/main: fix: scale encoding skip phantom data (#3967) chore: make platform team code owner of CI settings.toml and localnet (#3957) fix: prefer finalize_signed_extrinsic in engine (#3956) fix: CanonicalAssetPair encoding issue (#3958) chore(bouncer): Update sdk to 0.0.40 (#3945) fix: tweak cli generate-keys output (#3943) chore: add `preinst` script unit tests 🧪 (#3942) Better LP/Broker API RPC Errors (#3931) fix: update substrate ref to use Kademlia fix (#3941) doc: update funding readme with redemption restrictions (#3914) feat: PRO-474 broadcast safe mode (#3902) feat: more forgiving dot address parsing (#3938) fix: duplicate logging (#3939) feat: new lp interface (#3886) # Conflicts: # Cargo.lock # state-chain/cf-integration-tests/Cargo.toml # state-chain/cf-integration-tests/src/authorities.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.