Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer finalize_signed_extrinsic in engine #3956

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

dandanlen
Copy link
Collaborator

See #3557 - this should have been cherry-picked to main but wasn't.

@dandanlen dandanlen enabled auto-merge (squash) September 6, 2023 17:19
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #3956 (7d3c74b) into main (a841d84) will increase coverage by 0%.
Report is 1 commits behind head on main.
The diff coverage is 40%.

@@          Coverage Diff          @@
##            main   #3956   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        366     366           
  Lines      56789   56790    +1     
  Branches   56789   56790    +1     
=====================================
+ Hits       40947   40953    +6     
+ Misses     13756   13751    -5     
  Partials    2086    2086           
Files Changed Coverage Δ
engine/src/p2p/peer_info_submitter.rs 0% <0%> (ø)
engine/src/witness/btc.rs 61% <0%> (ø)
...ked_chain_source/chunked_by_time/chain_tracking.rs 0% <0%> (ø)
engine/src/witness/dot.rs 47% <0%> (ø)
engine/src/witness/eth/erc20_deposits.rs 0% <0%> (ø)
engine/src/witness/eth/ethereum_deposits.rs 34% <0%> (ø)
engine/src/witness/eth/key_manager.rs 0% <0%> (ø)
engine/src/witness/eth/state_chain_gateway.rs 0% <0%> (ø)
engine/src/witness/eth/vault.rs 0% <0%> (ø)
engine/src/state_chain_observer/sc_observer/mod.rs 37% <59%> (ø)
... and 1 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen merged commit 0fdf9e4 into main Sep 6, 2023
44 checks passed
@dandanlen dandanlen deleted the fix/use-finalize-signed-extrinsic-in-engine branch September 6, 2023 20:59
martin-chainflip pushed a commit that referenced this pull request Sep 7, 2023
* fix: CanonicalAssetPair encoding issue (#3958)

* fix: prefer finalize_signed_extrinsic in engine (#3956)

---------

Co-authored-by: Alastair Holmes <42404303+AlastairHolmes@users.noreply.github.com>
syan095 added a commit that referenced this pull request Sep 8, 2023
…on-integration

* origin/main:
  fix: scale encoding skip phantom data (#3967)
  chore: make platform team code owner of CI settings.toml and localnet (#3957)
  fix: prefer finalize_signed_extrinsic in engine (#3956)
  fix: CanonicalAssetPair encoding issue (#3958)
  chore(bouncer): Update sdk to 0.0.40 (#3945)
  fix: tweak cli generate-keys output (#3943)
  chore: add `preinst` script unit tests 🧪 (#3942)
  Better LP/Broker API RPC Errors (#3931)
  fix: update substrate ref to use Kademlia fix (#3941)
  doc: update funding readme with redemption restrictions (#3914)
  feat: PRO-474 broadcast safe mode (#3902)
  feat: more forgiving dot address parsing (#3938)
  fix: duplicate logging (#3939)
  feat: new lp interface (#3886)

# Conflicts:
#	Cargo.lock
#	state-chain/cf-integration-tests/Cargo.toml
#	state-chain/cf-integration-tests/src/authorities.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants