fix: scale encoding skip phantom data #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-98 Ethereum VaultRotationStatus not parsed in PolkaJS
DescriptionThis is annoying when debugging, it impossible to tell what state the eth vault rotation is in. Oddly enough, it works for Polkadot: |
kylezs
approved these changes
Sep 7, 2023
| @@ -189,6 +189,7 @@ pub trait CreatePolkadotVault: ApiCall<PolkadotCrypto> { | |||
| #[scale_info(skip_type_params(E))] | |||
| pub struct OpaqueApiCall<E> { | |||
| builder: PolkadotExtrinsicBuilder, | |||
| #[codec(skip)] | |||
There was a problem hiding this comment.
thought that's what the skip_type_params already does? 🤔
There was a problem hiding this comment.
No that just prevents the T: Encode + Decode from being implicitly inserted (ie. in this case, not adding skip_type_params would silently add E: Encode + Decode).
Codecov Report
@@ Coverage Diff @@
## main #3967 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 366 366
Lines 56790 56791 +1
Branches 56790 56791 +1
=====================================
- Hits 40959 40952 -7
- Misses 13750 13755 +5
- Partials 2081 2084 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlastairHolmes
approved these changes
Sep 7, 2023
syan095
added a commit
that referenced
this pull request
Sep 8, 2023
…on-integration * origin/main: fix: scale encoding skip phantom data (#3967) chore: make platform team code owner of CI settings.toml and localnet (#3957) fix: prefer finalize_signed_extrinsic in engine (#3956) fix: CanonicalAssetPair encoding issue (#3958) chore(bouncer): Update sdk to 0.0.40 (#3945) fix: tweak cli generate-keys output (#3943) chore: add `preinst` script unit tests 🧪 (#3942) Better LP/Broker API RPC Errors (#3931) fix: update substrate ref to use Kademlia fix (#3941) doc: update funding readme with redemption restrictions (#3914) feat: PRO-474 broadcast safe mode (#3902) feat: more forgiving dot address parsing (#3938) fix: duplicate logging (#3939) feat: new lp interface (#3886) # Conflicts: # Cargo.lock # state-chain/cf-integration-tests/Cargo.toml # state-chain/cf-integration-tests/src/authorities.rs
dandanlen
added a commit
that referenced
this pull request
Sep 18, 2023
dandanlen
added a commit
that referenced
this pull request
Sep 28, 2023
dandanlen
added a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-98
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Looks like this was due to phantom data not being skipped. (thanks to @AlastairHolmes for figuring this out)