feat: track btc fees on success #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4334 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 390 390
Lines 66259 66293 +34
Branches 66259 66293 +34
=====================================
- Hits 47292 47230 -62
- Misses 16602 16684 +82
- Partials 2365 2379 +14 ☔ View full report in Codecov by Sentry. |
AlastairHolmes
approved these changes
Dec 8, 2023
|
This waiting for something? |
|
@martin-chainflip was going to review |
kylezs
force-pushed
the
feat/bitcon-fee-witness
branch
4 times, most recently
from
630ca60
to
eb59185
Compare
martin-chainflip
approved these changes
Dec 12, 2023
kylezs
force-pushed
the
feat/bitcon-fee-witness
branch
2 times, most recently
from
e6de2dd
to
b0d63bb
Compare
| // Don't care to write custom deserializer for this | ||
| #[serde(skip)] | ||
| pub version_hex: Option<Vec<u8>>, |
There was a problem hiding this comment.
Why did you add this?
kylezs
force-pushed
the
feat/bitcon-fee-witness
branch
from
b0d63bb
to
97afabb
Compare
kylezs
added a commit
that referenced
this pull request
Dec 12, 2023
* feat: track btc fees on success * feat: use verbose block * doc: serde_json bug comment
syan095
added a commit
that referenced
this pull request
Dec 18, 2023
…-timeout * origin/main: feat: end to end network upgrade github action (#4274) feat: spec_version of PR is greater than spec version of current release (#4355) feat: enforce version is greater than release version on PRs to main (#4351) fix: btc witnesser test failing sometimes (#4353) fix: connections can become stale when reconnecting (#4310) chore: add `chainflip-rpc-node` systemd file 🚀 (#4352) feat: API Bins check SC compatibility (#4342) chore: update runtime spec checks ⛓️ (#4349) feat: Add version cmd to all bins (#4343) fix: changelog check 🤫 (#4348) chore: update docker tags 🐳 (#4347) chore: add runtime version check 👀 (#4344) feat: shave fees on ingress (#4335) pick/persa fixes (#4329) feat: track btc fees on success (#4334) ensure we dont create BTC transaction outputs below the bitcoin dust limit (#4340) fix: sweeping before withdrawal (#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1034
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
We want to track how much fees the vault has used to pay for egress.