feat: spec_version of PR is greater than spec version of current release #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
changed the title
kylezs
force-pushed
the
feat/enforce-bumped-spec-version
branch
from
89e29b7
to
22639a2
Compare
kylezs
force-pushed
the
feat/enforce-bumped-spec-version
branch
from
39b1a11
to
eebc50d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 393 393
Lines 66675 66675
Branches 66675 66675
=====================================
+ Hits 47497 47504 +7
+ Misses 16747 16744 -3
+ Partials 2431 2427 -4 ☔ View full report in Codecov by Sentry. |
kylezs
force-pushed
the
feat/enforce-bumped-spec-version
branch
from
4906c83
to
c7e9912
Compare
ahasna
approved these changes
Dec 15, 2023
kylezs
force-pushed
the
feat/enforce-bumped-spec-version
branch
from
c7e9912
to
b8f1eaa
Compare
marcellorigotti
approved these changes
Dec 15, 2023
syan095
added a commit
that referenced
this pull request
Dec 18, 2023
…-timeout * origin/main: feat: end to end network upgrade github action (#4274) feat: spec_version of PR is greater than spec version of current release (#4355) feat: enforce version is greater than release version on PRs to main (#4351) fix: btc witnesser test failing sometimes (#4353) fix: connections can become stale when reconnecting (#4310) chore: add `chainflip-rpc-node` systemd file 🚀 (#4352) feat: API Bins check SC compatibility (#4342) chore: update runtime spec checks ⛓️ (#4349) feat: Add version cmd to all bins (#4343) fix: changelog check 🤫 (#4348) chore: update docker tags 🐳 (#4347) chore: add runtime version check 👀 (#4344) feat: shave fees on ingress (#4335) pick/persa fixes (#4329) feat: track btc fees on success (#4334) ensure we dont create BTC transaction outputs below the bitcoin dust limit (#4340) fix: sweeping before withdrawal (#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Carrying on from #4351 , this one checks spec_version is bumped, which is required to push the runtime version update.
Also closes: PRO-919
Checklist
Please conduct a thorough self-review before opening the PR.