fix: sweeping before withdrawal #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlastairHolmes
force-pushed
the
fix/sweeping
branch
from
2a5eebd
to
ec478c8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4337 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 390 390
Lines 66256 66257 +1
Branches 66256 66257 +1
=====================================
- Hits 47233 47230 -3
- Misses 16646 16648 +2
- Partials 2377 2379 +2 ☔ View full report in Codecov by Sentry. |
martin-chainflip
approved these changes
Dec 11, 2023
|
Let's add a test case where a user has pending fees and withdraws more than their free balance. This should now work |
kylezs
pushed a commit
that referenced
this pull request
Dec 12, 2023
* doc: correct Error message * fix: sweep before withdrawal
tomjohnburton
pushed a commit
that referenced
this pull request
Dec 12, 2023
Co-authored-by: kylezs <zsembery.kyle@gmail.com> Co-authored-by: Martin Rieke <martin@chainflip.io> Co-authored-by: Jamie Ford <jamie@chainflip.io> Co-authored-by: Maxim Shishmarev <msgmaxim@gmail.com> Co-authored-by: Alastair Holmes <42404303+AlastairHolmes@users.noreply.github.com> Co-authored-by: Martin Rieke <121793148+martin-chainflip@users.noreply.github.com> Co-authored-by: dandanlen <3168260+dandanlen@users.noreply.github.com> Fix: CFE Witnessing, use parent block metadata when decoding events (#4331) fix: sweeping before withdrawal (#4337)
syan095
added a commit
that referenced
this pull request
Dec 18, 2023
…-timeout * origin/main: feat: end to end network upgrade github action (#4274) feat: spec_version of PR is greater than spec version of current release (#4355) feat: enforce version is greater than release version on PRs to main (#4351) fix: btc witnesser test failing sometimes (#4353) fix: connections can become stale when reconnecting (#4310) chore: add `chainflip-rpc-node` systemd file 🚀 (#4352) feat: API Bins check SC compatibility (#4342) chore: update runtime spec checks ⛓️ (#4349) feat: Add version cmd to all bins (#4343) fix: changelog check 🤫 (#4348) chore: update docker tags 🐳 (#4347) chore: add runtime version check 👀 (#4344) feat: shave fees on ingress (#4335) pick/persa fixes (#4329) feat: track btc fees on success (#4334) ensure we dont create BTC transaction outputs below the bitcoin dust limit (#4340) fix: sweeping before withdrawal (#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how this was happened, but sweeping was intended to occur before withdrawal automatically.
Also I fixed that error message you mentioned previously.