fix: don't abort broadcast if signers are unavailable #4104
Conversation
PRO-886 Don't abort broadcast if signers unavailable.
In We should be more defensive and instead schedule the broadcast to be retried as long as we haven't exhausted all of the singers (check FailedBroadcasters storage). |
Codecov Report
@@ Coverage Diff @@
## main #4104 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 377 377
Lines 59967 60035 +68
Branches 59967 60035 +68
=====================================
+ Hits 42717 42769 +52
- Misses 15008 15022 +14
- Partials 2242 2244 +2
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dandanlen
changed the title
| "Failed to select a signer for broadcast {:?}. Scheduling Retry", | ||
| broadcast_attempt.broadcast_attempt_id | ||
| ); | ||
| BroadcastRetryQueue::<T, I>::append(&broadcast_attempt); |
There was a problem hiding this comment.
We should also emit BroadcastRetryScheduled - can be pulled into a function since we do this inside transaction_signing_failure too
* origin/main: Feat: Set pool fees (#4050) fix: don't egress empty all_batch calls (#4102) fix: don't abort broadcast if signers are unavailable (#4104) feat: add restricted balances to AccountInfoV2 (#4048) feat: use snake case for lp api method names (#4108) feat: add expiry block to liquidity channel event (#4111) # Conflicts: # state-chain/custom-rpc/src/lib.rs # state-chain/runtime/src/lib.rs # state-chain/runtime/src/runtime_apis.rs
Pull Request
Closes: PRO-886
Checklist
Please conduct a thorough self-review before opening the PR.