feat: use snake case for lp api method names #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdibble
approved these changes
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #4108 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 377 377
Lines 59967 60022 +55
Branches 59967 60022 +55
=====================================
+ Hits 42717 42760 +43
- Misses 15008 15016 +8
- Partials 2242 2246 +4 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlastairHolmes
approved these changes
Oct 11, 2023
syan095
added a commit
that referenced
this pull request
Oct 12, 2023
* origin/main: Feat: Set pool fees (#4050) fix: don't egress empty all_batch calls (#4102) fix: don't abort broadcast if signers are unavailable (#4104) feat: add restricted balances to AccountInfoV2 (#4048) feat: use snake case for lp api method names (#4108) feat: add expiry block to liquidity channel event (#4111) # Conflicts: # state-chain/custom-rpc/src/lib.rs # state-chain/runtime/src/lib.rs # state-chain/runtime/src/runtime_apis.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Use snake case names for lp and broker rpcs.
broker rpcs are backwards-compatible.