Fix: CFE Witnessing, use parent block metadata when decoding events #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4331 +/- ##
=======================================
- Coverage 72% 71% -0%
=======================================
Files 385 390 +5
Lines 63554 66146 +2592
Branches 63554 66146 +2592
=======================================
+ Hits 45448 47068 +1620
- Misses 15749 16710 +961
- Partials 2357 2368 +11 ☔ View full report in Codecov by Sentry. |
kylezs
approved these changes
Dec 8, 2023
msgmaxim
reviewed
Dec 10, 2023
| tracing::info!( | ||
| "Witnessing transaction_succeeded. signature: {signature:?}" | ||
| ); | ||
| process_call( |
There was a problem hiding this comment.
Nit: this used to be properly indented.
msgmaxim
approved these changes
Dec 10, 2023
syan095
added a commit
that referenced
this pull request
Dec 12, 2023
…-timeout * origin/main: test: latest_then adapter testing (#4322) Fix: CFE Witnessing, use parent block metadata when decoding events (#4331) chore: remove unused Tailscale access (#4205) chore: clear CDN cache after releasing new apt packages 🪄 (#4325) hotfix: correct binary-subdir for production (#4328) fix: build sisyphos with production profile (#4327) Updated banana mode to adhere to new LP API (#4326) `cf_pool_orders` RPC call can return all Pool Orders (#4315) BTC reorg script for bouncer (#4302) fix: broker endpoint as env var (#4317)
kylezs
pushed a commit
that referenced
this pull request
Dec 12, 2023
…4331) * fix: use parent block when getting polkadot metadata * chore: addressing PR comments
tomjohnburton
pushed a commit
that referenced
this pull request
Dec 12, 2023
Co-authored-by: kylezs <zsembery.kyle@gmail.com> Co-authored-by: Martin Rieke <martin@chainflip.io> Co-authored-by: Jamie Ford <jamie@chainflip.io> Co-authored-by: Maxim Shishmarev <msgmaxim@gmail.com> Co-authored-by: Alastair Holmes <42404303+AlastairHolmes@users.noreply.github.com> Co-authored-by: Martin Rieke <121793148+martin-chainflip@users.noreply.github.com> Co-authored-by: dandanlen <3168260+dandanlen@users.noreply.github.com> Fix: CFE Witnessing, use parent block metadata when decoding events (#4331) fix: sweeping before withdrawal (#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1017
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The issue is caused by the
state_getRuntimeVersionrpc returning the new runtime version when called at the given block, but the events in that block at encoded with the old runtime.