Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sweeping before withdrawal #4337

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: sweeping before withdrawal #4337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb38e6
doc: correct Error message
AlastairHolmes Dec 11, 2023
ec478c8
fix: sweep before withdrawal
AlastairHolmes Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions state-chain/pallets/cf-lp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ pub mod pallet {
type SafeMode: Get<PalletSafeMode>;

/// The interface for sweeping funds from pools into free balance
type PoolApi: PoolApi;
type PoolApi: PoolApi<AccountId = <Self as frame_system::Config>::AccountId>;

/// Benchmark weights
type WeightInfo: WeightInfo;
}

#[pallet::error]
pub enum Error<T> {
/// The user does not have enough fund.
/// The user does not have enough funds.
InsufficientBalance,
/// The user has reached the maximum balance.
BalanceOverflow,
Expand Down Expand Up @@ -197,6 +197,9 @@ pub mod pallet {
Error::<T>::InvalidEgressAddress
);

// Sweep earned fees
T::PoolApi::sweep(&account_id)?;

// Debit the asset from the account.
Self::try_debit_account(&account_id, asset, amount)?;

Expand Down