Add gha-creds-*.json ignore #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cpanato
approved these changes
Jun 27, 2024
ltagliaferri
approved these changes
Jun 28, 2024
Signed-off-by: ltagliaferri <lisa.tagliaferri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Internal bugfix.
What should this PR do?
Prevent short-term token leakage.
Why are we making this change?
It's required to securely use the google-github-actions/auth documentation: https://github.com/google-github-actions/auth - though no technical control is in place to ensure the existence of this entry.
See google-github-actions/auth#298 for more context.
What are the acceptance criteria?
That it doesn't break tests.
How should this PR be tested?