add dashboard modules #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
reviewed
Dec 19, 2023
mattmoor
reviewed
Dec 19, 2023
mattmoor
reviewed
Dec 19, 2023
mattmoor
reviewed
Dec 19, 2023
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
reviewed
Dec 19, 2023
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
|
Dropped alert policies for now, I'll readd it later. Also dropped the project_id variable, which was only used to power the url output, which I've also removed. |
mattmoor
reviewed
Dec 19, 2023
mattmoor
reviewed
Dec 19, 2023
mattmoor
reviewed
Dec 19, 2023
dashboard/tiles/alert/main.tf
Outdated
| variable "alert_name" { type = string } | ||
|
|
||
| // https://cloud.google.com/monitoring/api/ref_v3/rest/v1/projects.dashboards#AlertChart | ||
| output "tile" { |
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
reviewed
Dec 19, 2023
dashboard/topic/dashboard.tf
Outdated
dashboard/subscription/dashboard.tf
Outdated
dashboard/subscription/README.md
Outdated
.github/workflows/documentation.yaml
Outdated
| @@ -15,6 +15,9 @@ jobs: | |||
| - cloudevent-trigger | |||
| - cloudevent-recorder | |||
| - networking | |||
| - dashboard/service | |||
| - dashboard/job | |||
| - dashboard/topic | |||
There was a problem hiding this comment.
drop for now
Suggested change
| - dashboard/topic |
| variable "secondary_reduce" { default = "REDUCE_NONE" } | ||
|
|
||
| // https://cloud.google.com/monitoring/api/ref_v3/rest/v1/projects.dashboards#XyChart | ||
| output "tile" { |
There was a problem hiding this comment.
We should rename the outputs too.
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves modules in from https://github.com/chainguard-dev/terraform-cloudrun-dashboard -- after this is merged we can archive that repo.
The new directory
./dashboardincludes:serviceandjob, which take a multi-regional Cloud Run Service or Job name and presents common metrics for themtopic, which takes a Pub/Sub topic prefix and presents common metrics for its subscribers, assuming they have that topic name as their subscription name prefixtiles, which provide reusable dashboard tile definitions, which we can extend over time.It also defines dashboards for the ingress and recorder services, and broker topics.