Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a bunch of CI stuff #16

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Just a bunch of CI stuff #16

merged 1 commit into from
Nov 17, 2022

Conversation

jdolitsky
Copy link
Contributor

@jdolitsky jdolitsky commented Nov 17, 2022

  • Run vuln scans on latest tag
  • Generate and upload build badge and cve badges to GCS
  • Update README format to include badges
  • Only run affected images on main push
  • Enable slack alerting via webhook (DISTROLESS_SLACK_WEBHOOK)
  • Remove .chainguard/ directory

Sneak peak of Badgeville (live at https://github.com/chainguard-images/images/blob/ci-stuff/README.md):

Screenshot 2022-11-17 at 2 38 33 AM

- Run vuln scans on latest tag
- Generate and upload build badge and cve badges to GCS
- Update README format to include badges
- Only run affected images on main push
- Enable slack alerting via webhook (DISTROLESS_SLACK_WEBHOOK)
- Remove .chainguard/ directory

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Copy link
Contributor

@amouat amouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we'll probably need to run it and iterate.

set -x
echo '${{ toJSON(matrix) }}' > inputs.json
for kv in `env | grep '^EXTRA_INPUT_' | sed 's/^EXTRA_INPUT_//'`; do
k="$(echo "${kv}" | cut -d "=" -f1 | tr '[:upper:]' '[:lower:]' | sed -r 's/(.)_+(.)/\1\U\2/g;s/^[a-z]/\U&/' | sed 's/.*/\l&/')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not gonna lie, this scares me a little.

for _, tag := range strings.Split(image.ApkoAdditionalTags, ",") {
tmp = append(tmp, fmt.Sprintf("`%s`", tag))
// TODO: support images with multiple extra tags (not just latest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this as a task/issue if you've not already

@jdolitsky jdolitsky merged commit c32fce1 into main Nov 17, 2022
@amouat
Copy link
Contributor

amouat commented Nov 17, 2022

Hmm, just realised I'm on the hook if this goes mental and continuously spams slack 😂

@amouat amouat deleted the ci-stuff branch November 17, 2022 10:46
@luhring
Copy link
Contributor

luhring commented Nov 17, 2022

Two things from me:

  1. I don't think we should be showing vuln counts from scanners for Wolfi images until they support Wolfi.
  2. Is the CVE badge generation process intended to be temporary? Since this data is so dynamic, my thinking is we'd want to source that from a separate backend at some point, and not require a bunch of PR+approval+merge cycles.

@jdolitsky
Copy link
Contributor Author

jdolitsky commented Nov 17, 2022

@amouat - opened this to track the "latest" TODO: #17

@luhring - opened this to figure out CVE badges: #18

jdolitsky added a commit that referenced this pull request Nov 17, 2022
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Use separate Slack webhook for vulnerability scans
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Use separate Slack webhook for vulnerability scans
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
AUTO: Adds project board syncer for image issues
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Use separate Slack webhook for vulnerability scans
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Signed-off-by: Adrian Mouat <adrian@chainguard.dev>
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Put back to what I want to happen
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Print logs to stderr instead of file
jdolitsky pushed a commit that referenced this pull request Nov 17, 2022
Cleanup repo to reflect new GitHub org etc.
jdolitsky pushed a commit that referenced this pull request Dec 1, 2022
Signed-off-by: Adrian Mouat <adrian@chainguard.dev>
jdolitsky pushed a commit that referenced this pull request Dec 1, 2022
Cleanup repo to reflect new GitHub org etc.
jdolitsky pushed a commit that referenced this pull request Dec 1, 2022
AUTO: Adds project board syncer for image issues
developer-guy pushed a commit to Dentrax/images that referenced this pull request Feb 12, 2024
…d-images#16)

Bumps [google-github-actions/get-gke-credentials](https://github.com/google-github-actions/get-gke-credentials) from 0 to 1.
- [Release notes](https://github.com/google-github-actions/get-gke-credentials/releases)
- [Changelog](https://github.com/google-github-actions/get-gke-credentials/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/get-gke-credentials@v0...v1)

---
updated-dependencies:
- dependency-name: google-github-actions/get-gke-credentials
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants