Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ruby #37

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Migrate ruby #37

merged 3 commits into from
Nov 18, 2022

Conversation

imjasonh
Copy link
Member

I think I don't quite have the ruby-3.X tags figured out, monopod readme fails.

Signed-off-by: Jason Hall jason@chainguard.dev

Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest the following for apko filenames:

  • configs/migration-30.apko.yaml
  • configs/migration-31.apko.yaml

I'd suggest configs/migration-3.0.apko.yaml, but I think monopod might get confused on the multiple periods... could fix that too

images/ruby/image.yaml Outdated Show resolved Hide resolved
images/ruby/image.yaml Outdated Show resolved Hide resolved
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

monopod might get confused on the multiple periods

I think it's getting confused by .s in the package name too...

images/ruby/image.yaml Outdated Show resolved Hide resolved
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@jdolitsky jdolitsky merged commit 0d6c730 into main Nov 18, 2022
@jdolitsky jdolitsky deleted the migrate-ruby branch November 18, 2022 21:43
@jdolitsky jdolitsky mentioned this pull request Nov 18, 2022
22 tasks
jdolitsky added a commit that referenced this pull request Dec 1, 2022
developer-guy pushed a commit to Dentrax/images that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants