Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: when server starts, current and pending jobs start before the cache is created #597

Closed
tahini opened this issue Mar 14, 2023 · 0 comments · Fixed by #598
Closed

jobs: when server starts, current and pending jobs start before the cache is created #597

tahini opened this issue Mar 14, 2023 · 0 comments · Fixed by #598
Labels
bug Something isn't working
Milestone
Batch Calculation...

Comments

@tahini
Copy link
Collaborator

tahini commented Mar 14, 2023

If the server restarts with the RECREATE_CACHE parameter, the cache may not exist at start and the calculation tasks will all return missing data. They should be queued only after the cache is complete
@tahini tahini added the bug Something isn't working label Mar 14, 2023
tahini added a commit to tahini/transition that referenced this issue Mar 14, 2023
@tahini
Wait for cache creation before the socket server starts
768d217 
Fixes chairemobilite#597

Batch calculations require the cache to exist. If we run the cache
creation asynchronously, tasks may be restarted/enqueued before it is
completed and the results will be wrong at best and potentially
invalid if the trRouting server starts with incomplete data. We should
wait for the cache to be completely saved before allowing client
connections.
@tahini tahini mentioned this issue Mar 14, 2023
Merged
kaligrafy pushed a commit that referenced this issue Mar 14, 2023
@tahini @kaligrafy
Wait for cache creation before the socket server starts
98a8156 
Fixes #597

Batch calculations require the cache to exist. If we run the cache
creation asynchronously, tasks may be restarted/enqueued before it is
completed and the results will be wrong at best and potentially
invalid if the trRouting server starts with incomplete data. We should
wait for the cache to be completely saved before allowing client
connections.
florencelauer pushed a commit to mahdiguermache/transition that referenced this issue Mar 28, 2023
@tahini @florencelauer
Wait for cache creation before the socket server starts
cf86bb8 
Fixes chairemobilite#597

Batch calculations require the cache to exist. If we run the cache
creation asynchronously, tasks may be restarted/enqueued before it is
completed and the results will be wrong at best and potentially
invalid if the trRouting server starts with incomplete data. We should
wait for the cache to be completely saved before allowing client
connections.
florencelauer pushed a commit to mahdiguermache/transition that referenced this issue Apr 10, 2023
@tahini @florencelauer
Wait for cache creation before the socket server starts
20156b1 
Fixes chairemobilite#597

Batch calculations require the cache to exist. If we run the cache
creation asynchronously, tasks may be restarted/enqueued before it is
completed and the results will be wrong at best and potentially
invalid if the trRouting server starts with incomplete data. We should
wait for the cache to be completely saved before allowing client
connections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Batch Calculation / OD Trip routing f...
Development

Successfully merging a pull request may close this issue.

Wait for cache creation before the socket server starts tahini/transition
1 participant
@tahini