Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TypedArray updates to index handling #1391

Closed
bterlson opened this issue Aug 5, 2016 · 5 comments
Closed

Implement TypedArray updates to index handling #1391

bterlson opened this issue Aug 5, 2016 · 5 comments
Assignees
@atulkatti
Labels
ES Spec Changed

Comments

@bterlson
Copy link
Contributor

bterlson commented Aug 5, 2016

ECMAScript unified the handling of indexes across all the TypedArray and related data structures. A number of minor semantics have changed.
@akroshg
Copy link
Contributor

akroshg commented Nov 16, 2016

Isn't this the one what @ianwjhalliday is fixing?

@ianwjhalliday
Copy link
Collaborator

This looks like a superset of what I fixed.

I can revisit this later, or someone from the language team can pick this up and continue from my changes.

@dilijev
Copy link
Contributor

dilijev commented Nov 17, 2016

Adding references to other issues mentioned: #2014 #2016

@atulkatti atulkatti assigned atulkatti and unassigned suwc Dec 20, 2016
@atulkatti atulkatti mentioned this issue Dec 31, 2016
Merged
chakrabot pushed a commit that referenced this issue Jan 3, 2017
[MERGE #2289 @atulkatti] Resolves #1391: Implement TypedArray updates…
d0f4f88 
… to index handling.

Merge pull request #2289 from atulkatti:TypedArray.Issue1391

Resolves #1391: Implement TypedArray updates to index handling.
1. Also, made changes to ArrayBuffer and DataView as per the spec updates.
2. Added some more tests for DataView.
chakrabot pushed a commit that referenced this issue Jan 3, 2017
[1.4>master] [MERGE #2289 @atulkatti] Resolves #1391: Implement Typed…
26e3ccd 
…Array updates to index handling.

Merge pull request #2289 from atulkatti:TypedArray.Issue1391

Resolves #1391: Implement TypedArray updates to index handling.
1. Also, made changes to ArrayBuffer and DataView as per the spec updates.
2. Added some more tests for DataView.
@dilijev
Copy link
Contributor

dilijev commented Jan 11, 2017 •
edited
Loading

Fixed by #2289
Then reverted by #2350

@dilijev dilijev reopened this Jan 11, 2017
@atulkatti
Copy link
Contributor

The PR #2350 only reverted some changes that may cause integer overflow. However, other spec changes for issue #1391 have not been reverted. So this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atulkatti atulkatti

Labels
ES Spec Changed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bterlson @dilijev @ianwjhalliday @suwc @akroshg @atulkatti