update jenkins test names #1962
Conversation
|
|
||
| // params: Project, BaseTaskName, IsPullRequest (appends '_prtest') | ||
| def jobName = Utilities.getFullJobName(project, config, isPR) + customOption.replaceAll(/[-]+/, "_") | ||
| def jobName = Utilities.getFullJobName(project, config, isPR) |
There was a problem hiding this comment.
I like this change, it will make the names so that _prtest always appears at the end. Looks like we're running a --no-jit variant on xplat builds. This should probably be added to the build status tables mentioned in the linked issue.
|
@dilijev dont we have to update README too ? or we should update that in a separate PR? |
|
Yes, you'll need to update the README and the wiki to correspond to this change (keeping in mind that if you update them at the same time as this pull request, there will initially be some broken links until the new job names are generated). If you have the time to do that now, go ahead. Keep in mind only to update the README in the affected branches and only the Build Status tables in the wiki that are affected. Older branches will not be affected by this change. |
|
@obastemur you can merge this when ready |
|
@obastemur Any update here? Should we retarget this to latest master (or release/2.0) and get it merged in? |
|
@dilijev Thanks for the review |
…ed in #1962. Merge pull request #2634 from dilijev:fixbst See #1962 See microsoft/ChakraCore-wiki#32
Fixes #1933 and
no-jittest names