Fix #19: Fix Build Status table for changes introduced in Microsoft/ChakraCore#1962 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilijev
commented
Mar 4, 2017
Build-Status.md
Outdated
| | __Ubuntu 16.04 (x64)<sup>[s]</sup>__ | [![dslow_linux_s_debug][dslow_linux_s_dbgicon]][dslow_linux_s_dbglink] | [![dslow_linux_s_test][dslow_linux_s_testicon]][dslow_linux_s_testlink] | [![dslow_linux_s_release][dslow_linux_s_relicon]][dslow_linux_s_rellink] | | ||
| | __Ubuntu 16.04 (x64)<sup>[s][n]</sup>__ | * | [![dslow_linux_sn_test][dslow_linux_sn_testicon]][dslow_linux_sn_testlink] | * | | ||
| | __OS X 10.9 (x64)<sup>[a]</sup>__ | [![dslow_osx_a_debug][dslow_osx_a_dbgicon]][dslow_osx_a_dbglink] | [![dslow_osx_a_test][dslow_osx_a_testicon]][dslow_osx_a_testlink] | [![dslow_osx_a_release][dslow_osx_a_relicon]][dslow_osx_a_rellink] | | ||
| | __OS X 10.9 (x64)<sup>[s][n]</sup>__ | * | [![dslow_osx_sn_test][dslow_osx_sn_testicon]][dslow_osx_sn_testlink] | * | |
There was a problem hiding this comment.
There is a section in the dailies for NoJIT builds already. I wasn't sure if I should split these off or keep the Daily/Slow table consistent with the rolling builds table.
|
I will make a corresponding change to the README once this is merged. |
|
👍 |
|
Seems this fixed the pending OSX build status. |
|
This is a text-only change to the Wiki. I also updated the required checks for the master branch in the Microsoft/ChakraCore repo settings -- that's what fixed the issue. |
|
You are right, I entered this PR via link chakra-core/ChakraCore#2634. |
chakrabot
pushed a commit
to chakra-core/ChakraCore
that referenced
this pull request
Mar 4, 2017
…ed in #1962. Merge pull request #2634 from dilijev:fixbst See #1962 See microsoft/ChakraCore-wiki#32
|
Ah, I see. FWIW, that's also just a text-only change to the README. The relevant setting was in the GitHub repo metadata/settings, not in our sources. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
See chakra-core/ChakraCore#1962