WASM - fast array implementation #2100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create WebAssemblyArrayBuffer that forces to use VirtualAlloc on x64 Windows
|
Closing for now. |
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2017
Merge pull request #2423 from Cellule:wasm/fastarray Closes #1888 Related #2100 This PR implements the fast array (aka 8GB array) for WebAssembly on Windows x64. I have put the feature under a flag (turned on by default) to help with testing and possibly debugging future issues. This creates a new type of ArrayBuffer, `WebAssemblyArrayBuffer ` which, since the creation is controlled within WebAssembly, always allocate the buffer in virtual memory regardless of size or asm.js constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the bounds check in jited code on x64 Windows for heap access.
I targeted this change against release/1.4 to get the review going.
We should discuss if we want to push this change to the release branch or if we should keep it in master
Fixes #1888
Since we have more control on how the buffer is created in WebAssembly then asm.js, I decided to create the class WebAssemblyArrayBuffer which would
@MikeHolman Are there other places other than TransferInternal that can detach the buffer ?
@liminzhu @LouisLaf @EdMaurer Do we want to integrate this change to release/1.4 since it has a massive perf benefit or is it too late ?
This change is