Add prototype implementation for WebAssembly #60
Conversation
- fixed module SectEnd (DeclEnd), added function call decoding, and block control flow - fixed INT32 constant decoding bug where only the first byte was being decoded - enable If_Else ASTNode - Nop handling - fixed a bug in WasmBytecodeGenerator: when emitting Calls, should first test whether we've looked at all params before we try to read (and test for wnLIMIT) - fixed missing handling of non-void return implicit blocks. now the binary decoder is at parity with sexpr at least in terms of the basic.wast example. - This is one place where binary decoder and sexpr parser diverges. Sexpr parser needs to ReadFromCall() to consume the final RPAREN and discard it whereas a follow-up invocation of ReadFromCall() in the binary decoder will cause it to drop the subsequent byte. - fix for function call argument register allocation management - starting to implement loop and block labels and br
Getting function calls and loops working in the decoder and misc fixes
|
Hi @MikeHolman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| // | ||
| // Read the entire content as a binary block. | ||
| // | ||
| fread((void*)contents, sizeof(char), lengthBytes, file); |
There was a problem hiding this comment.
You should check the return value here for malformed files.
There was a problem hiding this comment.
addressed in my new PR
|
Discussed offline with @EdMaurer. We'll keep wasm in a separate branch until feature is stable and then merge back to master. I'll send out another PR against a Microsoft/wasm branch shortly. |
|
Moved to #63 |
To better facilitate collaboration on our WebAssembly implementation, I'd like to merge our prototype into master. Note that this is still not stable or complete and current API is for testing purposes only. It will change, frequently. Use is only available through WScript.LoadWasmFile in ch.exe, which uses the JsRunWasmScriptForTestOnly JSRT API.