WebAssembly prototype implementation #63
Conversation
- fixed module SectEnd (DeclEnd), added function call decoding, and block control flow - fixed INT32 constant decoding bug where only the first byte was being decoded - enable If_Else ASTNode - Nop handling - fixed a bug in WasmBytecodeGenerator: when emitting Calls, should first test whether we've looked at all params before we try to read (and test for wnLIMIT) - fixed missing handling of non-void return implicit blocks. now the binary decoder is at parity with sexpr at least in terms of the basic.wast example. - This is one place where binary decoder and sexpr parser diverges. Sexpr parser needs to ReadFromCall() to consume the final RPAREN and discard it whereas a follow-up invocation of ReadFromCall() in the binary decoder will cause it to drop the subsequent byte. - fix for function call argument register allocation management - starting to implement loop and block labels and br
Getting function calls and loops working in the decoder and misc fixes
|
Hi @MikeHolman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
If you have a chance could you incorporate my feedback from here: #62 ? |
|
@LouisLaf, @abchatra, @nmostafa, @naturaltransformation: can you review when you get a chance? |
|
@dilijev Done. And looks like copyright/EOL tests are passing now. |
|
@MikeHolman Yep, looks good. |
|
@dotnet-bot test this please |
|
@MikeHolman |
|
To keep things moving along, I'm going to merge this in (to the WebAssembly branch) so we can start putting in more changes on top. If you have any comments at this point, please open an issue. |
|
Squashed and merged in: e44a8b2 |
To better facilitate collaboration on our WebAssembly implementation, and have more iterative development, I'd like to merge our prototype into the Microsoft fork. Note that this is still not stable or complete, and it will change, frequently. Use is currently only available through WScript.LoadWasmFile in ch.exe (which uses the JsRunWasmScript JSRT API).