-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #6701
Update README.md #6701
Conversation
Fixed casing for some names and terms
Thanks for the PR @abatishchev Please could you also sign our contribution agreement? I know this is just a simple change but we ask for it for anything: |
Hi @rhuanjl, do I need to sign it if I contribute as a Microsoft employee? I'm, my internal alias is alexbat. |
Ideally yes - Microsoft are no longer maintaining CC - as it's been discontinued as a product see #6384 for more info if interested. The piece about exceptions for contributions on behalf of Microsoft was to cover any final contributions Microsoft made before ending support. |
Not a lawyer, but the first paragraph says I don't need to sign. |
You don't have to sign if you're contributing on behalf of microsoft and the work is covered by the existing license in License.txt. (I didn't expect that as - MS said they were ending all support/work on CC) That paragraph covers the situation if your contribution is part of your job for MS but not if you happen to be an MS employee but this is something you've done on your own time. |
hi @rhuanjl, I'm contributing this one minor change on behalf of Microsoft and under the existing MIT license but that Microsoft is indeed no longer supporting the project. I hope it'll be ok to check it in. Otherwise please close the PR. |
Please either accept the PR or close it. |
I feel like since the change is really minor and you are contributing on behalf of Microsoft (even if it does not officially provide support) it is OK to merge this in. |
Fixed casing for some names and terms