Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #6701

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Update README.md #6701

merged 3 commits into from
Sep 13, 2021

Conversation

abatishchev
Copy link
Contributor

Fixed casing for some names and terms

Fixed casing for some names and terms
@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 15, 2021

Thanks for the PR @abatishchev

Please could you also sign our contribution agreement? I know this is just a simple change but we ask for it for anything:
Add a commit that puts your name and github username at the bottom of this file in the same format as the ones already there: https://github.com/chakra-core/ChakraCore/blob/master/ContributionAgreement.md

@abatishchev
Copy link
Contributor Author

Hi @rhuanjl, do I need to sign it if I contribute as a Microsoft employee? I'm, my internal alias is alexbat.

@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 15, 2021

Ideally yes - Microsoft are no longer maintaining CC - as it's been discontinued as a product see #6384 for more info if interested.

The piece about exceptions for contributions on behalf of Microsoft was to cover any final contributions Microsoft made before ending support.

@abatishchev
Copy link
Contributor Author

Not a lawyer, but the first paragraph says I don't need to sign.
And to sign, I need to involve lawyers. As an employee, can't just sign. Last time it took a month to get approved (

@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 15, 2021

You don't have to sign if you're contributing on behalf of microsoft and the work is covered by the existing license in License.txt.

(I didn't expect that as - MS said they were ending all support/work on CC)

That paragraph covers the situation if your contribution is part of your job for MS but not if you happen to be an MS employee but this is something you've done on your own time.

@abatishchev
Copy link
Contributor Author

abatishchev commented Apr 19, 2021

hi @rhuanjl,
Let me reiterate my point:

I'm contributing this one minor change on behalf of Microsoft and under the existing MIT license but that Microsoft is indeed no longer supporting the project.

I hope it'll be ok to check it in. Otherwise please close the PR.

@abatishchev
Copy link
Contributor Author

Please either accept the PR or close it.

@ppenzin
Copy link
Member

ppenzin commented Sep 13, 2021

I feel like since the change is really minor and you are contributing on behalf of Microsoft (even if it does not officially provide support) it is OK to merge this in.

@ppenzin ppenzin merged commit 13b5403 into chakra-core:master Sep 13, 2021
@abatishchev abatishchev deleted the patch-1 branch September 13, 2021 04:28
@abatishchev abatishchev restored the patch-1 branch September 13, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants