Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improved alert statuses union types & fixed storybook examples #2167

Closed
wants to merge 1 commit into from
Closed

refactor: improved alert statuses union types & fixed storybook examples #2167

wants to merge 1 commit into from

Conversation

anuraghazra
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Storybook example changes

What is the current behavior?

Fixes: [ISSUE NUMBER]

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

I did not created separate PRs since the changes were very small.

Updated tooltip storybook example

Before:
image

After:
image

Btw i think tooltips should also have higher zIndex value, atleast more than the modal. 🤔

@vercel
Copy link

vercel bot commented Oct 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/hip71g09i
✅ Preview: https://chakra-ui-git-fork-anuraghazra-improve-alert-types.chakra-ui.vercel.app

@segunadebayo
Copy link
Member

Thanks for this PR @anuraghazra.

Due to the conflict, I've pushed the updates that were needed.

@anuraghazra anuraghazra deleted the improve-alert-types branch October 21, 2020 12:49
@anuraghazra
Copy link
Contributor Author

Okay no issues! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants