Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update portal and add nesting opt out #3210

Merged
merged 10 commits into from Jan 30, 2021
Merged

feat: update portal and add nesting opt out #3210

merged 10 commits into from Jan 30, 2021

Conversation

segunadebayo
Copy link
Member

@segunadebayo segunadebayo commented Jan 30, 2021

Closes #3196 #3201 #3213

📝 Description

Update portal API to include the following:

  • A way to mount portaled elements into custom container by passing containerRef
  • A way to opt out of nesting portal into parent portal's node by passing appendToParentPortal

Fixed issue where portal with zIndex container still renders things outside of view.

💣 Is this a breaking change (Yes/No):

No

@vercel
Copy link

vercel bot commented Jan 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/r2c8g7fqv
✅ Preview: https://chakra-ui-git-feat-portal.chakra-ui.now.sh

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2021

🦋 Changeset detected

Latest commit: 1ab9a6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@chakra-ui/modal Minor
@chakra-ui/tooltip Minor
@chakra-ui/menu Minor
@chakra-ui/portal Minor
@chakra-ui/docs Patch
@chakra-ui/react Patch
@chakra-ui/popover Patch
@chakra-ui/test-utils Patch
chakra-cra Patch
gatsby-starter-default Patch
chakra-nextjs Patch
chakra-nextjs-ts Patch
@chakra-ui/props-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested portals issue
2 participants