Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested portals issue. #692

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Nested portals issue. #692

merged 1 commit into from
Feb 1, 2021

Conversation

nicolad
Copy link
Contributor

@nicolad nicolad commented Jan 31, 2021

See: chakra-ui/chakra-ui#3196 and chakra-ui/chakra-ui#3210


Before:

screenie-2021-01-31_14.34.09.mp4

After:

screenie-2021-01-31_14.34.57.mp4

@nicolad nicolad added T: bug 🐛 type: FIX - any bug fixes T: refactor 🛠 type: MOD - changes in existing functionality labels Jan 31, 2021
@nicolad nicolad added this to In progress in Barista EDTR via automation Jan 31, 2021
@nicolad nicolad self-assigned this Jan 31, 2021
Copy link
Contributor

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, on a Sunday 😄

Barista EDTR automation moved this from In progress to Approved Jan 31, 2021
@nicolad nicolad merged commit 41708e2 into master Feb 1, 2021
Barista EDTR automation moved this from Approved to Completed Feb 1, 2021
@nicolad nicolad deleted the chakra-nested-portals-issue branch February 1, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐛 type: FIX - any bug fixes T: refactor 🛠 type: MOD - changes in existing functionality
Projects
Barista EDTR
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants