Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not overwritable aria label prop on TagCloseButton #5599

Merged

Conversation

m4x3d
Copy link
Contributor

@m4x3d m4x3d commented Feb 16, 2022

Closes #5587

📝 Description

Change order of aria-label prop on TagCloseButton to be overwritable

⛳️ Current behavior (updates)

aria-label of TagCloseButton can not be overwritten

🚀 New behavior

aria-label of TagCloseButton can be overwritten

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2022

🦋 Changeset detected

Latest commit: 07e48f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@chakra-ui/tag Patch
@chakra-ui/react Patch
@chakra-ui/props-docs Patch
@chakra-ui/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/9FjAfJYEnfvDxB3m2H3yi6WSuJ5m
✅ Preview: https://chakra-ui-storybook-git-fork-m4x3d-fix-not-ove-69606a-chakra-ui.vercel.app

@m4x3d m4x3d changed the title Fix/not overwritable aria label prop fix: not overwritable aria label prop on TagCloseButton Feb 16, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07e48f9:

Sandbox Source
create-react-app-ts Configuration

@TimKolberger TimKolberger merged commit 5d4abe4 into chakra-ui:main Feb 17, 2022
@TimKolberger
Copy link
Contributor

Thank you @m4x3d 💖🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for properties of a component to be overriden via props
2 participants