Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C2] Rename ROLE_RRHH constant to ROLE_HR #5660

Closed
ywarnier opened this issue Jul 12, 2024 · 3 comments
Closed

[C2] Rename ROLE_RRHH constant to ROLE_HR #5660

ywarnier opened this issue Jul 12, 2024 · 3 comments

Comments

@ywarnier
Copy link
Member

This is a small change to increase understandability of the code, but it is necessary to do it pre-alpha as it potentially changes the string un user.roles for a few users.

The ROLE_RRHH constant name stems from Spanish where abbreviations for plurals (like Human Resources) is written in duplicate letters (so RRHH for Recursos Humanos).

This is confusing while reading it for a non-Spanish speaker and we have conventions for all-English code and comments, so... let's apply that while we can.

  • Change constant name everywhere
  • Add a Migration to update the user.roles string to replace ROLE_RRHH by ROLE_HR

Also, we'll slowly remove the notion of "Manager" in some of the terms we use around HR. The HR role is not only for the HR manager but for the whole HR team, potentially. But these changes will be added progressively (and later).

@ywarnier ywarnier added this to the 2.0 milestone Jul 12, 2024
christianbeeznest added a commit to christianbeeznest/chamilo-lms that referenced this issue Jul 13, 2024
christianbeeznest added a commit that referenced this issue Jul 13, 2024
Internal: Rename ROLE_RRHH to ROLE_HR and update user.roles migration - refs #5660
@christianbeeznest
Copy link
Contributor

christianbeeznest commented Jul 13, 2024

It is merged to master for testing. Thanks for confirmation :)
Clean cache and yarn

php bin/console cache:clear
yarn dev

@ywarnier
Copy link
Member Author

php bin/console doctrine:migrations:execute Chamilo\\CoreBundle\\Migrations\\Schema\\V200\\Version20240713125400
probably also necessary for this one

@ywarnier
Copy link
Member Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants