Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to get legacy configuration values #4032

Closed
wants to merge 4 commits into from

Conversation

AngelFQC
Copy link
Member

No description provided.

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2021

Code Climate has analyzed commit dac0ab9 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 7

View more on Code Climate.

Copy link
Member

@jmontoyaa jmontoyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I think is not a good idea to mix legacy and v2 settings. Better to move that config in the TicketSettingsSchema

@AngelFQC AngelFQC closed this Oct 20, 2021
@AngelFQC AngelFQC deleted the legacy-config branch October 20, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants