Gradebook: Fixes and enhancements for certificate handling in documents and gradebook - #5074 #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -1200,7 +1200,7 @@ public static function replace_user_info_into_html( | |||
| $my_content_html = $repo->getResourceFileContent($doc); | |||
| $all_user_info = self::get_all_info_to_certificate( | |||
| $user_id, | |||
| $courseInfo, | |||
| $course_id, | |||
There was a problem hiding this comment.
Variable "course_id" is not in valid camel caps format
| @@ -1230,11 +1230,12 @@ | |||
| * | |||
| * @return array | |||
| */ | |||
| public static function get_all_info_to_certificate($user_id, $course_info, $sessionId, $is_preview = false) | |||
| public static function get_all_info_to_certificate($user_id, $courseId, $sessionId, $is_preview = false) | |||
There was a problem hiding this comment.
Method name "DocumentManager::get_all_info_to_certificate" is not in camel caps format
| @@ -1230,11 +1230,12 @@ | |||
| * | |||
| * @return array | |||
| */ | |||
| public static function get_all_info_to_certificate($user_id, $course_info, $sessionId, $is_preview = false) | |||
| public static function get_all_info_to_certificate($user_id, $courseId, $sessionId, $is_preview = false) | |||
There was a problem hiding this comment.
Variable "user_id" is not in valid camel caps format
| @@ -1230,11 +1230,12 @@ | |||
| * | |||
| * @return array | |||
| */ | |||
| public static function get_all_info_to_certificate($user_id, $course_info, $sessionId, $is_preview = false) | |||
| public static function get_all_info_to_certificate($user_id, $courseId, $sessionId, $is_preview = false) | |||
There was a problem hiding this comment.
Variable "is_preview" is not in valid camel caps format
| { | ||
| $info_list = []; | ||
| $user_id = (int) $user_id; | ||
| $sessionId = (int) $sessionId; | ||
| $course_info = api_get_course_info_by_id($courseId); |
There was a problem hiding this comment.
Variable "course_info" is not in valid camel caps format
|
Code Climate has analyzed commit c457ad2 and detected 29 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.