Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User: Verify and improve Terms & Conditions and GDPR - refs #5121 #5189

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 7.29927% with 127 lines in your changes are missing coverage. Please review.

Project coverage is 41.45%. Comparing base (9b0e6fc) to head (bfa7400).
Report is 2 commits behind head on master.

Files Patch % Lines
src/CoreBundle/Controller/LegalController.php 0.00% 100 Missing ⚠️
src/CoreBundle/Entity/Legal.php 14.28% 12 Missing ⚠️
src/CoreBundle/Repository/LegalRepository.php 0.00% 8 Missing ⚠️
src/CoreBundle/Controller/SecurityController.php 57.14% 6 Missing ⚠️
...eBundle/Controller/Admin/IndexBlocksController.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5189      +/-   ##
============================================
- Coverage     41.56%   41.45%   -0.12%     
- Complexity     9824     9855      +31     
============================================
  Files           782      783       +1     
  Lines         39428    39542     +114     
============================================
+ Hits          16389    16392       +3     
- Misses        23039    23150     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,192 @@
<?php

declare(strict_types=1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single space around assignment operators

use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

#[Route('/legal')]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

use Symfony\Component\Routing\Annotation\Route;

#[Route('/legal')]
class LegalController
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use "/**" style comments for a class comment

#[Route('/legal')]
class LegalController
{
#[Route('/save', name: 'chamilo_core_legal_save', methods: ['POST'])]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

class LegalController
{
#[Route('/save', name: 'chamilo_core_legal_save', methods: ['POST'])]
public function saveLegal(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use "/**" style comments for a function comment

Copy link

codeclimate bot commented Feb 26, 2024

Code Climate has analyzed commit bfa7400 and detected 53 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 48
Complexity 1
Clarity 1
Bug Risk 3

View more on Code Climate.

@christianbeeznest christianbeeznest merged commit 01e62ee into chamilo:master Feb 26, 2024
4 of 9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant