-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User: Verify and improve Terms & Conditions and GDPR - refs #5121 #5189
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5189 +/- ##
============================================
- Coverage 41.56% 41.45% -0.12%
- Complexity 9824 9855 +31
============================================
Files 782 783 +1
Lines 39428 39542 +114
============================================
+ Hits 16389 16392 +3
- Misses 23039 23150 +111 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,192 @@ | |||
<?php | |||
|
|||
declare(strict_types=1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a single space around assignment operators
use Symfony\Component\HttpFoundation\Response; | ||
use Symfony\Component\Routing\Annotation\Route; | ||
|
||
#[Route('/legal')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
use Symfony\Component\Routing\Annotation\Route; | ||
|
||
#[Route('/legal')] | ||
class LegalController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must use "/**" style comments for a class comment
#[Route('/legal')] | ||
class LegalController | ||
{ | ||
#[Route('/save', name: 'chamilo_core_legal_save', methods: ['POST'])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
class LegalController | ||
{ | ||
#[Route('/save', name: 'chamilo_core_legal_save', methods: ['POST'])] | ||
public function saveLegal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must use "/**" style comments for a function comment
Code Climate has analyzed commit bfa7400 and detected 53 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.