Internal: Fix gradebook import error during session creation - refs BT#21541 #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoDucou
reviewed
Apr 21, 2024
| @@ -3176,7 +3176,7 @@ public function getDataAndFormattedValues($itemId, $filter = false, $onlyShow = | |||
| } | |||
| break; | |||
| case self::FIELD_TYPE_SELECT_MULTIPLE: | |||
| $displayedValue = $valueData['value']; | |||
| $displayedValue = $valueData['field_value']; | |||
There was a problem hiding this comment.
Hola @christianbeeznest
Porque cambias este valor ?
Estas revertiendo un cambio que hice el viernes para que se muestre bien el extra field.
No veo una razon relacionado con tu commit aqui.
Me indicas para ver si puedo regresar el cambio que habia hecho en el commit b6b52db
There was a problem hiding this comment.
Hola @NicoDucou , me ocurría un error revisando los issues relacionado con gradebook y sesiones me parece, el value era undefined y como los demás están con field_value también lo puse eso , aver reviertalo a tu cambio porfa y si logro reproducir el error después te lo digo para que lo verifiques .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.