#36 Actions should return the value through vuex #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 74.49% 74.66% +0.17%
==========================================
Files 9 9
Lines 149 150 +1
Branches 37 37
==========================================
+ Hits 111 112 +1
Misses 19 19
Partials 19 19
Continue to review full report at Codecov.
|
@MutationAction should not return the returned action as it should be accessed from the state after it was mutated
rumbcam
force-pushed
the
feature/actions-should-return
branch
from
afc6426
to
f07f0e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed it so that @actions will return, but @MutationAction will not return as I figure that a MutationAction is designed to mutate the state and you should then access the value off the state not from the returned value from the action. I have also added a test of my own to test the MutationAction